Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paths to logics #6945

Merged
merged 7 commits into from
Nov 9, 2021
Merged

Add paths to logics #6945

merged 7 commits into from
Nov 9, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Now that we deprecated webpack and babel-loader, we're no longer using the kea babel plugin. This means we get errors referencing paths like "kea.logic.23" instead of "scenes.insights.insightLogic". This PR upgrades to a new kea-typegen that with --write-paths also writes paths to logics if there are none.

How did you test this code?

  • Made the changes, went through each file to make sure there's no namespace conflict (e.g. "scenes.bla" and "scenes.bla.subbla" for logics would cause issues), and made sure it still runs locally. There were no conflicts and it ran locally.
  • I could see all the paths inside the redux devtools now:

image

@mariusandra mariusandra enabled auto-merge (squash) November 9, 2021 07:51
@mariusandra mariusandra merged commit 26a3b06 into master Nov 9, 2021
@mariusandra mariusandra deleted the add-paths-to-logics branch November 9, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants